sema: fix int enum implicit cast to float. #6977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassiebeckley
approved these changes
Oct 21, 2024
|
@llvm-beanz : is something holding this review? |
|
@damyanp since I'm changing common sema I'd prefer to have MS take a look |
llvm-beanz
reviewed
Nov 8, 2024
An implicit cast from int enum to a float should be a Floating_Integral cast, not an Integral_Conversion. Fixes microsoft#6884 Signed-off-by: Nathan Gauër <[email protected]>
Signed-off-by: Nathan Gauër <[email protected]>
Keenuts
requested review from
llvm-beanz
and removed request for
farzonl and
damyanp
|
@llvm-beanz PTAL |
1 similar comment
|
@llvm-beanz PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implicit cast from int enum to a float should be a Floating_Integral cast, not an Integral_Conversion.
Fixes #6884