Add .NET 9 target for WinRT.Runtime.dll #1843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
user/sergiopedri/cswinrt-net9
branch
from
2ac8ec3 to
55e16a8
Compare
Sergio0694
force-pushed
the
user/sergiopedri/cswinrt-net9
branch
from
6c5ab62 to
334136f
Compare
Sergio0694
force-pushed
the
user/sergiopedri/cswinrt-net9
branch
from
c2ef284 to
fb7b997
Compare
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
| <LibBuildTFMs Condition="'$(CIBuildReason)' == 'CI'">netstandard2.0;net8.0</LibBuildTFMs> | ||
| <LibBuildTFMsNoNetStandard>net8.0</LibBuildTFMsNoNetStandard> | ||
| <LibBuildTFMsNoNetStandard>net8.0;net9.0</LibBuildTFMsNoNetStandard> | ||
| <LibBuildTFMsNoNetStandard Condition="'$(CIBuildReason)' == 'CI'">net8.0</LibBuildTFMsNoNetStandard> | ||
| <TestsBuildTFMs>net8.0-windows10.0.19041.0</TestsBuildTFMs> | ||
| <TestsBuildTFMs Condition="'$(CIBuildReason)' == 'CI'">net8.0-windows10.0.19041.0</TestsBuildTFMs> |
There was a problem hiding this comment.
We probably also want to run our object lifetime tests on .NET 9 too and functional?
manodasanW
reviewed
Jan 18, 2025
| @@ -1092,7 +1092,7 @@ public void Dispose() | |||
|
|
|||
| public static new unsafe MarshalerArray CreateMarshalerArray(T[] array) | |||
| { | |||
| #if NET | |||
| #if NET && !NET9_0_OR_GREATER | |||
There was a problem hiding this comment.
We probably should add some non blittable array marshaling test in functional tests for when aot is enabled and are running for .NET 9.
And we should at least manually re-enable the below authoring tests we disabled and confirm it works now on .NET 9. Note vcxproj will need to be changed to build for .NET 9 which is why I am not sure if we want to do that change in the pipeline yet.
Sergio0694
force-pushed
the
user/sergiopedri/cswinrt-net9
branch
from
4931a49 to
9e20452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
MarshalNonBlittablework on AOT