Skip to content

Agent Framework SDK #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrunalhirve128 merged 23 commits into from
Oct 31, 2025
Merged

Agent Framework SDK #5

mrunalhirve128 merged 23 commits into from
Oct 31, 2025

Conversation

@mrunalhirve128
Copy link
Contributor

@mrunalhirve128 mrunalhirve128 commented Oct 29, 2025 •
edited
Loading

Added tooling sdk for Agents Framework

Limitation with Microsoft.Extensions.AI Framework Architecture
The Microsoft.Extensions.AI framework (which likely underlies the agent infrastructure) follows an immutable configuration pattern where:
• Tool definitions are part of the agent's core configuration
• The agent's execution context is optimized around a fixed set of tools
• Runtime tool modification would require rebuilding the entire agent context
Hence there is no way to update the agent with new tools

Package Update
microsoft-agents-a365-observability-core[jaeger] depends on opentelemetry-exporter-jaeger >= 1.20.0
microsoft-agents-a365-tooling-extensions-agentframework[dev] depends on agent-framework-azure-ai >= 0.1.0 which in turn depends on agent-framework-core
agent-framework-core depends on opentelemetry-exporter-otlp-proto-grpc >= 1.36.0
There's a conflict with the protobuf and googleapis-common-protos versions between these OpenTelemetry packages

@mrunalhirve128 mrunalhirve128 marked this pull request as ready for review October 31, 2025 01:58
Copilot AI review requested due to automatic review settings October 31, 2025 01:58
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors MCP tool registration services across multiple frameworks to simplify initialization and improve logging consistency. It also adds a new Agent Framework extension library with comprehensive tooling support.

  • Simplified constructor patterns by removing optional dependency injection parameters
  • Added consistent logging throughout MCP tool registration workflows
  • Created new Agent Framework extension package with MCP tool registration capabilities

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mcp_tool_registration_service.py (semantickernel) Removed optional constructor parameters, now directly instantiates McpToolServerConfigurationService and removed null check
mcp_tool_registration_service.py (openai) Added copyright header, logger support, and comprehensive logging statements throughout tool registration workflow
setup.py (agentframework) New setup file with dynamic versioning based on UTC timestamp
pyproject.toml (agentframework) New project configuration for Agent Framework extension package
mcp_tool_registration_service.py (agentframework) New implementation of MCP tool registration service for Agent Framework with full logging support
init.py (agentframework/services) New module initialization exporting McpToolRegistrationService
init.py (agentframework) New package initialization with comprehensive module documentation
README.md (agentframework) New comprehensive documentation for the Agent Framework extension library

Copilot AI review requested due to automatic review settings October 31, 2025 02:36
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings October 31, 2025 03:01
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 31, 2025 03:17
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

@mrunalhirve128
Update libraries/microsoft-agents-a365-tooling-extensions-openai/micr…
313c904 
…osoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings October 31, 2025 03:21
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings October 31, 2025 03:37
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings October 31, 2025 03:41
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings October 31, 2025 04:02
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

pontemonti
pontemonti previously approved these changes Oct 31, 2025
View reviewed changes
Copilot AI review requested due to automatic review settings October 31, 2025 17:05
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.

@mrunalhirve128 mrunalhirve128 merged commit 7d7ae9c into main Oct 31, 2025
8 checks passed
@pontemonti pontemonti deleted the users/mrunalhirve/AgentFrameworkSDKInPython branch December 5, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahuldevikar761 rahuldevikar761 rahuldevikar761 left review comments

Copilot code review Copilot Copilot left review comments

@pontemonti pontemonti pontemonti approved these changes

@juliomenendez juliomenendez Awaiting requested review from juliomenendez

@nikhilNava nikhilNava Awaiting requested review from nikhilNava

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrunalhirve128 @pontemonti @rahuldevikar761