add tests

Author: nikhilc-microsoft

tests/observability/core/test_agent365.py

@@ -9,6 +9,9 @@
     Agent365ExporterOptions,
 )
 from microsoft_agents_a365.observability.core.trace_processor import SpanProcessor
+from opentelemetry import trace as otel_trace
+from opentelemetry.sdk.resources import Resource
+from opentelemetry.sdk.trace import TracerProvider
 
 
 class TestAgent365Configure(unittest.TestCase):
@@ -19,6 +22,16 @@ def setUp(self):
         self.mock_token_resolver = Mock()
         self.mock_token_resolver.return_value = "test_token_123"
 
+    def tearDown(self):
+        """Clean up after each test."""
+        # Reset the telemetry manager singleton state
+        from microsoft_agents_a365.observability.core.config import _telemetry_manager
+
+        _telemetry_manager._tracer_provider = None
+        _telemetry_manager._span_processors = {}
+
+        otel_trace._TRACER_PROVIDER = None
+
     def test_configure_basic_functionality(self):
         """Test configure function with basic parameters and legacy parameters."""
         # Test basic configuration without exporter_options
@@ -112,6 +125,105 @@ def test_span_processor_creation(self):
         processor = SpanProcessor()
         self.assertIsNotNone(processor, "SpanProcessor should be created successfully")
 
+    def test_configure_prevents_duplicate_initialization(self):
+        """Test that calling configure() multiple times doesn't reinitialize."""
+        result1 = configure(
+            service_name="test-service-1",
+            service_namespace="test-namespace-1",
+        )
+        self.assertTrue(result1)
+
+        with patch(
+            "microsoft_agents_a365.observability.core.config._telemetry_manager._logger"
+        ) as mock_logger:
+            result2 = configure(
+                service_name="test-service-2",
+                service_namespace="test-namespace-2",
+            )
+            self.assertTrue(result2)
+            mock_logger.warning.assert_called_once()
+            self.assertIn("already configured", mock_logger.warning.call_args[0][0].lower())
+
+    @patch("microsoft_agents_a365.observability.core.config.is_agent365_exporter_enabled")
+    @patch("microsoft_agents_a365.observability.core.config.TracerProvider")
+    def test_configure_creates_new_tracer_provider(self, mock_provider_class, mock_is_enabled):
+        """Test configure() creates new TracerProvider when none exists and adds processors."""
+        mock_is_enabled.return_value = False
+
+        new_provider = TracerProvider(
+            resource=Resource.create({
+                "service.name": "test-service",
+                "service.namespace": "test-namespace",
+            })
+        )
+        mock_provider_class.return_value = new_provider
+
+        result = configure(service_name="test-service", service_namespace="test-namespace")
+        self.assertTrue(result)
+
+        # Verify both processors were added by inspecting the MultiSpanProcessor
+
+        active_processor = new_provider._active_span_processor
+        self.assertIsNotNone(active_processor)
+
+        # MultiSpanProcessor has a _span_processors list
+        processors = active_processor._span_processors
+        self.assertEqual(
+            len(processors), 2, "Should have 2 processors: BatchSpanProcessor and SpanProcessor"
+        )
+
+        # Verify types of processors
+        processor_types = [type(p).__name__ for p in processors]
+        self.assertIn("BatchSpanProcessor", processor_types)
+        self.assertIn("SpanProcessor", processor_types)
+
+    @patch("microsoft_agents_a365.observability.core.config.is_agent365_exporter_enabled")
+    @patch("microsoft_agents_a365.observability.core.config.trace.get_tracer_provider")
+    def test_configure_uses_existing_tracer_provider(self, mock_get_provider, mock_is_enabled):
+        """Test configure() uses existing TracerProvider and adds processors without calling set_tracer_provider."""
+        mock_is_enabled.return_value = False
+
+        existing_provider = TracerProvider(
+            resource=Resource.create({"service.name": "existing-service"})
+        )
+        mock_get_provider.return_value = existing_provider
+
+        with patch(
+            "microsoft_agents_a365.observability.core.config._telemetry_manager._logger"
+        ) as mock_logger:
+            with patch(
+                "microsoft_agents_a365.observability.core.config.trace.set_tracer_provider"
+            ) as mock_set:
+                result = configure(service_name="new-service", service_namespace="new-namespace")
+                self.assertTrue(result)
+
+                # Verify existing provider was detected
+                info_calls = [call[0][0] for call in mock_logger.info.call_args_list]
+                self.assertTrue(
+                    any("Detected existing TracerProvider" in msg for msg in info_calls)
+                )
+
+                # Verify didn't call set_tracer_provider
+                mock_set.assert_not_called()
+
+                # Verify both processors were added by inspecting the MultiSpanProcessor
+
+                active_processor = existing_provider._active_span_processor
+                self.assertIsNotNone(active_processor)
+
+                # MultiSpanProcessor has a _span_processors list
+                processors = active_processor._span_processors
+                self.assertEqual(
+                    len(processors),
+                    2,
+                    "Should have 2 processors: BatchSpanProcessor and SpanProcessor",
+                )
+
+                # Verify types of processors
+                processor_types = [type(p).__name__ for p in processors]
+                self.assertIn("BatchSpanProcessor", processor_types)
+                self.assertIn("SpanProcessor", processor_types)
+
 
 if __name__ == "__main__":
     unittest.main()

tests/observability/core/test_agent365_exporter.py

@@ -372,6 +372,18 @@ def test_export_error_logging(self, mock_logger):
             "No spans with tenant/agent identity found; nothing exported."
         )
 
+    def test_exporter_is_internal(self):
+        """Test that _Agent365Exporter is marked as internal/private.
+
+        The underscore prefix convention indicates this class is internal to the SDK
+        and should not be instantiated directly by developers.
+        """
+
+        self.assertTrue(
+            _Agent365Exporter.__name__.startswith("_"),
+            "Exporter class should be prefixed with underscore to indicate it's private/internal",
+        )
+
 
 if __name__ == "__main__":
     unittest.main()