Mak te A365exporter internal and final so its not instantiated outside the core sdk

Author: nikhilc-microsoft

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py

@@ -10,7 +10,7 @@
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import BatchSpanProcessor, ConsoleSpanExporter
 
-from .exporters.agent365_exporter import Agent365Exporter
+from .exporters.agent365_exporter import _Agent365Exporter
 from .exporters.agent365_exporter_options import Agent365ExporterOptions
 from .exporters.utils import is_agent365_exporter_enabled
 from .trace_processor.span_processor import SpanProcessor
@@ -147,7 +147,7 @@ def _configure_internal(
         }
 
         if is_agent365_exporter_enabled() and exporter_options.token_resolver is not None:
-            exporter = Agent365Exporter(
+            exporter = _Agent365Exporter(
                 token_resolver=exporter_options.token_resolver,
                 cluster_category=exporter_options.cluster_category,
                 use_s2s_endpoint=exporter_options.use_s2s_endpoint,

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/__init__py

@@ -0,0 +1,3 @@
+# Agent365Exporter is not exported intentionally.
+# It should only be used internally by the observability core module.
+__all__ = ["Agent365ExporterOptions"]

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py

@@ -9,7 +9,7 @@
 import threading
 import time
 from collections.abc import Callable, Sequence
-from typing import Any
+from typing import Any, final
 
 import requests
 from microsoft_agents_a365.runtime.power_platform_api_discovery import PowerPlatformApiDiscovery
@@ -36,7 +36,8 @@
 logger = logging.getLogger(__name__)
 
 
-class Agent365Exporter(SpanExporter):
+@final
+class _Agent365Exporter(SpanExporter):
     """
     Agent 365 span exporter for Agent 365:
       * Partitions spans by (tenantId, agentId)

tests/observability/core/test_agent365.py

@@ -61,13 +61,13 @@ def test_configure_with_exporter_options_and_parameter_precedence(self, mock_is_
         )
         self.assertTrue(result, "configure() should return True with exporter_options")
 
-    @patch("microsoft_agents_a365.observability.core.config.Agent365Exporter")
+    @patch("microsoft_agents_a365.observability.core.config._Agent365Exporter")
     @patch("microsoft_agents_a365.observability.core.config.BatchSpanProcessor")
     @patch("microsoft_agents_a365.observability.core.config.is_agent365_exporter_enabled")
     def test_batch_span_processor_and_exporter_called_with_correct_values(
         self, mock_is_enabled, mock_batch_processor, mock_exporter
     ):
-        """Test that BatchSpanProcessor and Agent365Exporter are called with correct values from exporter_options."""
+        """Test that BatchSpanProcessor and _Agent365Exporter are called with correct values from exporter_options."""
         # Enable Agent365 exporter for this test
         mock_is_enabled.return_value = True
 

tests/observability/core/test_agent365_exporter.py

@@ -6,7 +6,7 @@
 
 from microsoft_agents_a365.observability.core.constants import GEN_AI_AGENT_ID_KEY, TENANT_ID_KEY
 from microsoft_agents_a365.observability.core.exporters.agent365_exporter import (
-    Agent365Exporter,
+    _Agent365Exporter,
 )
 from opentelemetry.sdk.trace import ReadableSpan
 from opentelemetry.sdk.trace.export import SpanExportResult
@@ -21,7 +21,7 @@ def setUp(self):
         self.mock_token_resolver.return_value = "test_token_123"
 
         # Don't patch the class in setUp, do it per test
-        self.exporter = Agent365Exporter(
+        self.exporter = _Agent365Exporter(
             token_resolver=self.mock_token_resolver, cluster_category="test"
         )
 
@@ -216,7 +216,7 @@ def test_partitioning_by_scope(self):
     def test_s2s_endpoint_path_when_enabled(self):
         """Test 4: Test that S2S endpoint path is used when use_s2s_endpoint is True."""
         # Arrange - Create exporter with S2S endpoint enabled
-        s2s_exporter = Agent365Exporter(
+        s2s_exporter = _Agent365Exporter(
             token_resolver=self.mock_token_resolver, cluster_category="test", use_s2s_endpoint=True
         )
 
@@ -252,7 +252,7 @@ def test_s2s_endpoint_path_when_enabled(self):
     def test_default_endpoint_path_when_s2s_disabled(self):
         """Test 5: Test that default endpoint path is used when use_s2s_endpoint is False."""
         # Arrange - Create exporter with S2S endpoint disabled (default behavior)
-        default_exporter = Agent365Exporter(
+        default_exporter = _Agent365Exporter(
             token_resolver=self.mock_token_resolver, cluster_category="test", use_s2s_endpoint=False
         )