Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uaiohttpclient: Implement parsing and handling HTTP auth URLs #867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on May 29, 2024

  1. uaiohttpclient: Implement parsing and handling HTTP auth URLs

    Allows HTTP Basic Auth URLs being passed, parsed and handled correctly
    to authorise against a server expecting that.
    This is a simplification, completely ignoring if the server supports or
    asks for HTTP Basic Auth. We simply format and set the header if
    the URL indicates so.
    
    This also fixes parsing URLs containing a colon (':') /not/ indicating
    a custom port (but e.g. the seperation between user and password as part
    of the HTTP Basic Auth credentials).
    
    Previously, the lib died ungracefully when parsing an URL containing
    HTTP Basic Auth credentials, as it was always expecting at most only one
    colon (':') and also the part coming afterwards being neccesarily a
    number (port).
    Mirko Vogt committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3e8c309 View commit details
    Browse the repository at this point in the history