Starter overhaul: Thorntail -> Quarkus 2.7.5.Final#469
Open
Karm wants to merge 2 commits intomicroprofile:mainfrom
Open
Starter overhaul: Thorntail -> Quarkus 2.7.5.Final#469Karm wants to merge 2 commits intomicroprofile:mainfrom
Karm wants to merge 2 commits intomicroprofile:mainfrom
Conversation
Karm
force-pushed
the
thorntail-to-quarkus
branch
4 times, most recently
from
14d6877 to
66e3e1f
Compare
This was referenced Apr 12, 2022
Contributor
Author
|
@Emily-Jiang ready for debate & review. |
Contributor
Author
|
2022-04-25 call summary with @Emily-Jiang (correct me if I am missing anything)
|
Emily-Jiang
reviewed
Apr 25, 2022
Member
Emily-Jiang
left a comment
Emily-Jiang
left a comment
There was a problem hiding this comment.
@Karm the current starter runs on microprofile 3.3
Contributor
Author
|
The PR is not forgotten, it's still on the list. |
Karm
force-pushed
the
thorntail-to-quarkus
branch
from
66e3e1f to
c7b9b94
Compare
Contributor
Author
|
Hello @Emily-Jiang, I think I've got it. It works with Liberty too now except for some UI font glitches that are something beyond my Liberty-fu capacity. Might look O.K. in your browser. Could you try it out yourself, please? LibertyOpen: http://localhost:9080/starter/index.xhtml QuarkusRunning with Quarkus: Navigate to http://127.0.0.1:8080 to see the app. |
Member
|
Here is the screen shot for Open Liberty. It looks not quite righ. |
Contributor
Author
|
The issue is still relevant, but I have no updates to share ATM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the Starter from EOL'd Thorntail to the contemporary Quarkus 2.7.5.Final.
It simplifies the project struct pom and it brings testing to the Quarkus Test framework, so the Quarkus is the one runtime to run/test Starter with.
All Docker packaging was updated too, and tested. The packaging is simplified and documented.
Attempting to thoroughly test that all works as expected, the test suite is updated with additional stabilization, ported to Quarkus Test framework (used to be Arquillian), and last but not least, it was made Windows compatible for Gradle based projects too.
The GitHub CI runs Windows too now 🥳 .
The JSF capability was made possible thanks to MyFaces Quarkus extension https://github.com/apache/myfaces/tree/master/extensions/quarkus.
Since this is a big step, we can talk about it on the next Starter call.