Support for Keycloak v17+ in AuthorizationServer::infer #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@sdelamo could you let the GitHub Actions run, please? In this case I could see if the build pass, at least, and fix the necessary stuff until the review starts. Thanks 🙏 |
|
I will check this pr soon. |
|
Just a side note: this one alone won't solve the issue with Keycloak and RP initiated logouts, #1049 should solve the latter one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keycloak 17+ doesn't have the
/auth/fragment in its pre-set URLs, therefore the original logic inAuthorizationServeris outdated, and it's not possible to infer the right type of newer Keycloak instances based on the URL of the issuer. The biggest consequence of this is thatEndSessionEndpointResolveris not able to register the right end session endpoint for Keycloak.