Implement support for custom Api Versions in informers (#639) #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
is it possible to add a test? |
|
done ! |
n0tl3ss
reviewed
Jun 11, 2024
| // Model's api-group prefix to kubernetes api-group | ||
| private final Map<String, String> preBuiltApiGroups = new HashMap<>(); | ||
|
|
||
| // Model's api-version midfix to kubernetes api-version | ||
| private final List<String> preBuiltApiVersions = new ArrayList<>(); | ||
|
|
||
| // This allows parsing custom (not included in kubernetes core) api versions | ||
| private final Pattern customVersionParser = Pattern.compile("(V[a-z1-9]+)[A-Z]+[a-zA-Z0-9]+"); |
There was a problem hiding this comment.
Did you get this regex from somewhere or have you created it?
I saw that you said this are valid:
- V1MySettings
- V1alpha1Operation
what about:
- Vtest1Operation
There was a problem hiding this comment.
I actually created it myself based on all the CRDs I know from my previous experiences but looking slightly more for references, I just found this one: https://github.com/kubernetes/apimachinery/blob/master/pkg/util/version/version.go#L38
Do you think we should use it ?
There was a problem hiding this comment.
Any update @n0tl3ss ?
There was a problem hiding this comment.
Hi @cambierr can you update the PR with the regex that you have mentioned.
n0tl3ss
approved these changes
Jul 18, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the support of custom api versions to the informer library as discussed in #639