Update Typescript Declarations index.d.ts#47
Open
Starrah wants to merge 1 commit intomicromatch:masterfrom
Open
Update Typescript Declarations index.d.ts#47Starrah wants to merge 1 commit intomicromatch:masterfrom
Starrah wants to merge 1 commit intomicromatch:masterfrom
Conversation
Details:
1. Add @types/picomatch as dependency, and import {PicomatchOptions} from "picomatch".
2. add more function signatures to separate different type of return value: when returnIndex=true, the return value is number, otherwise the return value is boolean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
returnIndex=true, the return value is number, otherwise the return value is boolean.Motivation:
Old type declarations will raise TS complie error when using
picomatchoptions, such as the following code:With the modifications in this PR, the error is corrected, and the type declaration is matched with what is described in the README.md.