-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plot method for eigenvalues #160
base: devel
Are you sure you want to change the base?
Conversation
Signed-off-by: Daena Rys <[email protected]>
Commenting wirh phone so little bit hard, but: Eventhough SCE method, in description of x say that the obkect must be TreeSE (not SCE). Some users might not knoe that TreeSE is actually SCE and this might be confusing Structure the function so that. One internal functiona prepares the data and another internal function plots the data (.scree_plotter). Put these show.* parameters as a hidden parameters of .scree_plotter |
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
i have added update to consider actual variance explained( |
Signed-off-by: Daena Rys <[email protected]>
You could also support MDS (aka PCoA). For other ordinations this is not well defined I think. |
if (!dimred %in% reducedDimNames(x)) { | ||
stop("'dimred' must specify a valid reducedDim.", call. = FALSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also support index (that could be supported but not described in the documentation --> simpler when less options)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this. Do you mean subsetting the vector based on indices for example indices = c(4,5)
?
Also RDA is based on eigenvalues-eigenvectors |
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
issue: #159