Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plot method for eigenvalues #160

Open
wants to merge 10 commits into
base: devel
Choose a base branch
from
Open

add plot method for eigenvalues #160

wants to merge 10 commits into from

Conversation

Daenarys8
Copy link
Contributor

issue: #159

@TuomasBorman
Copy link
Contributor

Commenting wirh phone so little bit hard, but:

Eventhough SCE method, in description of x say that the obkect must be TreeSE (not SCE). Some users might not knoe that TreeSE is actually SCE and this might be confusing

Structure the function so that. One internal functiona prepares the data and another internal function plots the data (.scree_plotter).

Put these show.* parameters as a hidden parameters of .scree_plotter

Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
@Daenarys8
Copy link
Contributor Author

i have added update to consider actual variance explained(VarExplained) by each PCi in runPCA as it does not return eigenvalues. What other reducedDim are to be supported?

Signed-off-by: Daena Rys <[email protected]>
@Daenarys8 Daenarys8 self-assigned this Oct 28, 2024
@antagomir
Copy link
Member

antagomir commented Nov 3, 2024

You could also support MDS (aka PCoA). For other ordinations this is not well defined I think.

R/plotScree.R Outdated Show resolved Hide resolved
R/plotScree.R Outdated Show resolved Hide resolved
Comment on lines +86 to +87
if (!dimred %in% reducedDimNames(x)) {
stop("'dimred' must specify a valid reducedDim.", call. = FALSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also support index (that could be supported but not described in the documentation --> simpler when less options)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this. Do you mean subsetting the vector based on indices for example indices = c(4,5)?

R/plotScree.R Outdated Show resolved Hide resolved
R/plotScree.R Outdated Show resolved Hide resolved
R/plotScree.R Outdated Show resolved Hide resolved
R/plotScree.R Outdated Show resolved Hide resolved
@TuomasBorman
Copy link
Contributor

You could also support MDS (aka PCoA). For other ordinations this is not well defined I think.

Also RDA is based on eigenvalues-eigenvectors

Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Signed-off-by: Daena Rys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants