agglomeration functions and na.rm #658
Open
+540
−414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this issue #654, we noticed that the use of
na.rm
is not intuitive in agglomeration functions.This PR adds option for excluding NAs in agglomeration functions (
agglomerateByRank
,agglomerateByVariable
andagglomerateByPrevalence
).na.rm
now works similarly tosum(x, na.rm = TRUE)
in these aforementioned functions.In
agglomerateByVariable
na.rm
controlled whether we remove those rows that did not have any group information, i.e., their group wasNA
. Now this parameter is namedgroup.rm
.In
agglomerateByRank
na.rm
controlled whether we remove those rows that did not have any taxonomy information. Now this parameter is calledempty.rows.rm
.These parameter names can be still modified. Maybe we could unify so that both would have parameter
empty.row.rm
.na.rm
is now handled in mia, but I opened issue inscuttle
if this can be handled directly in function that mia utilizes: LTLA/scuttle#33Let's wait until the issue in scuttle is solved.