Prevent script execution from remote source #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was referenced in #16
e.g. when remote file has some failing js, it gets executed instantly and breaks the plugin. Check https://jsfiddle.net/xgbnmf5a/
The problem arise only when using
.html()
in jQuery 1.8.3. The bug was fixed in 1.9.Workaround: use
innerHTML
instead of.html()
.See jQuery bug reports here:
https://bugs.jquery.com/ticket/13634
https://bugs.jquery.com/ticket/10470
https://bugs.jquery.com/ticket/11795