Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bugfixes, thanks mypy #289

Closed
5 tasks done
0x5c opened this issue Oct 29, 2020 · 0 comments · Fixed by #290
Closed
5 tasks done

Small bugfixes, thanks mypy #289

0x5c opened this issue Oct 29, 2020 · 0 comments · Fixed by #290
Assignees
@0x5c
Labels
code cleanup Simple linting stuff easy Easy to do/implement priority-med This issue should be worked on when possible
Milestone
v2.5.0

Comments

@0x5c
Copy link
Member

0x5c commented Oct 29, 2020 •
edited
Loading

Those are the easy to fix ones

  • 3. extctl: Mypy does not like that we call the result of get_command(), perhaps we could call it directly
  • 4. add_react(): the type is too strict
  • 5. error handling: ctx.invoked_with could be None
  • 9. embedfactory: mypy does not like like directly passing ctx.author as text=
  • 10. addreact: none has no id

Related to #288
@0x5c 0x5c added code cleanup Simple linting stuff priority-med This issue should be worked on when possible easy Easy to do/implement labels Oct 29, 2020
@0x5c 0x5c added this to the v2.4.2 milestone Oct 29, 2020
@0x5c 0x5c self-assigned this Oct 29, 2020
@0x5c 0x5c mentioned this issue Oct 29, 2020
Open
5 tasks
0x5c added a commit that referenced this issue Oct 29, 2020
@0x5c
Fixed numerous small potential bugs
1995239 
- Most are typing related

Fixes #289
@0x5c 0x5c mentioned this issue Oct 29, 2020
Merged
@0x5c 0x5c closed this as completed in #290 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x5c 0x5c

Labels
code cleanup Simple linting stuff easy Easy to do/implement priority-med This issue should be worked on when possible
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Fixed numerous small potential bugs miaowware/qrm2
1 participant
@0x5c