Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple typing issues #288

Open
5 tasks
0x5c opened this issue Oct 28, 2020 · 1 comment
Open
5 tasks

Multiple typing issues #288

0x5c opened this issue Oct 28, 2020 · 1 comment
Assignees
Labels
code cleanup Simple linting stuff investigate This issue needs investigation priority-med This issue should be worked on when possible refactor This will require refactoring code

Comments

@0x5c
Copy link
Member

0x5c commented Oct 28, 2020

This is an issue to list all currently found typing and typing-related issues in qrm that will require refactoring, or depend on Bolt features..

  • 1. Mypy is mad each time we access bot.qrm or a member of such

  • 2. Mypy is mad when we set a category in the command/group decorator

  • 6. Error handling: mypy is angry that we try to append something to embed.description

  • 7. globalchannelconverter: yells that a method is missing yet present from class

  • 8. "": "TYPE MISMATCH"

@0x5c 0x5c added code cleanup Simple linting stuff refactor This will require refactoring code priority-med This issue should be worked on when possible labels Oct 28, 2020
@0x5c 0x5c self-assigned this Oct 28, 2020
@0x5c
Copy link
Member Author

0x5c commented Oct 29, 2020

Those are the easy to fix ones

  • 3. extctl: Mypy does not like that we call the result of get_command(), perhaps we could call it directly
  • 4. add_react(): the type is too strict
  • 5. error handling: ctx.invoked_with could be None
  • 9. embedfactory: mypy does not like like directly passing ctx.author as text=
  • 10. addreact: none has no id

Breaking up into another issue: #289

@0x5c 0x5c mentioned this issue Oct 29, 2020
5 tasks
@0x5c 0x5c added the investigate This issue needs investigation label Oct 30, 2020
@0x5c 0x5c added this to the v2.6.0 - Major Refactor milestone Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Simple linting stuff investigate This issue needs investigation priority-med This issue should be worked on when possible refactor This will require refactoring code
Projects
None yet
Development

No branches or pull requests

2 participants