adding more test cases for UserSelector

test_util.py

@@ -51,6 +51,16 @@ def test_select_non_excluded_3_users(self):
             selected = selector.select(users)
             self.assertEqual(selected, expected_selection)
 
+    def test_select_non_excluded_3_users_with_ids(self):
+        selector = UserSelector()
+        users = [(1, "Alice"), (1, "Alice"), (2, "Bob"), (2, "Bob"), (3, "Charlie"), (3, "Charlie"), (3, "Charlie")]
+        selector.history = [(1, "Alice"), (2, "Bob"), (3, "Charlie")]
+
+        expected_selections = [(1, "Alice"), (2, "Bob"), (3, "Charlie"), (1, "Alice"), (2, "Bob"), (3, "Charlie")]
+        for expected_selection in expected_selections:
+            selected = selector.select(users)
+            self.assertEqual(selected, expected_selection)
+
     def test_select_never_picks_last_n_from_history(self):
         for _ in range(100):
             selector = UserSelector()

util.py

@@ -1,8 +1,8 @@
 import logging
 import random
 import time
+from typing import Any
 from typing import Callable
-from typing import List, Any
 
 from telegram import Update
 from telegram.ext import ContextTypes
@@ -40,7 +40,7 @@ def __init__(self):
         self.history = []
         self.selection_gap = 2
 
-    def select(self, users: List[str]) -> [str | None]:
+    def select(self, users):
         if not users:
             raise ValueError('users list should not be empty')