Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old setup.py code was unable to build the fastgrab module, due to missing numpy during the setup stage. It's unlikely that anyone ever installed this library via PyPi in the past, due to this oversight.
However, it's possible to patch the build process class to do late injection of the numpy headers path. This technique comes from the following post:
https://stackoverflow.com/a/21621689/8874388
It works by telling setuptools that we need numpy, and then modifying the build process class to add numpy's path before we actually build fastgrab.
Further fixes were performed to make it buildable on Python 3.12 with the latest libraries.
Closes #18.