Fix/enable service state and class id enumeration #73
Conversation
Change defaults back to original values
Change defaults back to original values
|
Hi @liamcarlos, thanks for your work. In fact, I am thinking of removing the enable service and only using the lifecycle services. On the other hand, I'm not getting the problem with the |
|
@mgonzs13 Ahh I see I misunderstood the class id variable. I quickly trained a model with one class because I was only looking for one type of object, and I wanted a way to go through the number of detections for that object. Is there a way to do that? Would that be done with tracking? My thinking initially was to label them (incorrectly with an integer in class id i.e. object 1, 2, 3..) and then stop the feed with setting enable to false to prevent loss of detections and addition of new detections. Do you use this package to perform a function similar to this? |
Hi there,
I've been using this package for the object detection portion of my project and it has been a huge help, so I just want to thank you first for putting this out here!
The first change I made to enable callback is because I found that if I tried setting the same state twice (i.e. setting enable to false when it is already false) it freezes, I assume waiting for a response from SetBool which doesn't have a way for dealing with this? I'm not sure, but that change should remedy that circumstance so it would return a response to indicate that enable has not been changed and not freeze activities.
Secondly, the enumeration change I made a while ago, but I believe that that line was not going through the number of detections properly, hence the manual incrementations. I would like to revisit this revision though, because I believe it can be done more intelligently and handle an issue I think it is causing by incrementing previous detections instead of recognizing the original detections? I don't know, but I am interested in learning more about this package and how to use it! Thanks you!