Skip to content

Conversation

@jeqcho
Copy link

@jeqcho jeqcho commented Dec 6, 2025

Closes #318

Copy link
Collaborator

@cdonnay cdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really fantastic, just a few small documentation notes and maybe one switch to using a scipy implementation of FW.

Thank you so much for contributing! Give us a ping when you're ready for a final review.

@cdonnay
Copy link
Collaborator

cdonnay commented Dec 10, 2025

Can you also change the target branch to 3.4.0 which is our next release? Thanks!

@jeqcho jeqcho changed the base branch from main to 3.4.0 December 11, 2025 02:22
@jeqcho
Copy link
Author

jeqcho commented Dec 11, 2025

Can you also change the target branch to 3.4.0 which is our next release? Thanks!

Changed!

Copy link
Collaborator

@cdonnay cdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me; I'll go ahead and merge. Thanks a ton @jeqcho, this is really stellar!!!!

@cdonnay cdonnay merged commit c6953d0 into mggg:3.4.0 Dec 11, 2025
2 of 3 checks passed
@cdonnay cdonnay mentioned this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Schulze method

2 participants