-
Notifications
You must be signed in to change notification settings - Fork 20
Implement Schulze #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Schulze #320
Conversation
cdonnay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really fantastic, just a few small documentation notes and maybe one switch to using a scipy implementation of FW.
Thank you so much for contributing! Give us a ping when you're ready for a final review.
|
Can you also change the target branch to 3.4.0 which is our next release? Thanks! |
Changed! |
cdonnay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me; I'll go ahead and merge. Thanks a ton @jeqcho, this is really stellar!!!!
Closes #318