adds filename-format rule #1092
Merged
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
approved these changes
Oct 30, 2024
ccoVeille
reviewed
Nov 2, 2024
alexandear
reviewed
Nov 4, 2024
| }} | ||
| } | ||
|
|
||
| func (r *FilenameFormatRule) getMsgForNonAsciiChars(str string) string { |
There was a problem hiding this comment.
Suggested change
| func (r *FilenameFormatRule) getMsgForNonAsciiChars(str string) string { | |
| func (r *FilenameFormatRule) getMsgForNonASCIIChars(str string) string { |
alexandear
reviewed
Nov 4, 2024
Comment on lines
+523
to
+524
| ## filename-format | ||
| _Description_: enforces conventions on source file names. By default, the rule enforces filenames of the form `^[_A-Za-z0-9][_A-Za-z0-9-]*.go$`: Optionally, the rule can be configured to enforce other forms. |
There was a problem hiding this comment.
Suggested change
| ## filename-format | |
| _Description_: enforces conventions on source file names. By default, the rule enforces filenames of the form `^[_A-Za-z0-9][_A-Za-z0-9-]*.go$`: Optionally, the rule can be configured to enforce other forms. | |
| ## filename-format | |
| _Description_: enforces conventions on source file names. By default, the rule enforces filenames of the form `^[_A-Za-z0-9][_A-Za-z0-9-]*.go$`: Optionally, the rule can be configured to enforce other forms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1090 by adding a new rule with a broad scope of enforcing filename format