Skip to content

refactor: improve error handling and assertions in tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandear merged 1 commit into from
May 19, 2025
Merged

refactor: improve error handling and assertions in tests #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 19 additions & 60 deletions resolve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,18 @@
package dots

import (
"log"
"runtime"
"strings"
"testing"
)

func TestResolveNoArgs(t *testing.T) {
result, err := Resolve([]string{}, []string{})

files := []string{}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != len(files) {
t.Error("Matched different number of files")
}

if err != nil {
log.Fatal(err)
if len(result) != 0 {
t.Errorf("Matched different number of files: got=%v, want=0", len(result))
}
}

Expand All @@ -41,24 +32,18 @@ func TestResolve(t *testing.T) {
}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != len(files) {
t.Error("Matched different number of files")
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), len(files))
}

if err != nil {
log.Fatal(err)
}

for _, r := range result {
matched := false
for _, e := range files {
matched = matched || strings.HasSuffix(r, e)
}
if !matched {
t.Error("Not supposed to match: " + r)
t.Errorf("Not supposed to match: %v", r)
}
}
}
Expand All @@ -71,24 +56,18 @@ func TestPackageResolve(t *testing.T) {
}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != len(files) {
t.Error("Matched different number of files")
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), len(files))
}

if err != nil {
log.Fatal(err)
}

for _, r := range result {
matched := false
for _, e := range files {
matched = matched || strings.HasSuffix(r, e)
}
if !matched {
t.Error("Not supposed to match: " + r)
t.Errorf("Not supposed to match: %v", r)
}
}
}
Expand All @@ -99,15 +78,10 @@ func TestSkipWildcard(t *testing.T) {
files := map[string]bool{}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != len(files) {
t.Error("Matched different number of files")
}

if err != nil {
log.Fatal(err)
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), len(files))
}
}

Expand All @@ -119,23 +93,18 @@ func TestPackageWildcard(t *testing.T) {
}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}
if len(result) != len(files) {
t.Error("Matched different number of files")
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), len(files))
}

if err != nil {
log.Fatal(err)
}

for _, r := range result {
matched := false
for _, e := range files {
matched = matched || strings.HasSuffix(r, e)
}
if !matched {
t.Error("Not supposed to match: " + r)
t.Errorf("Not supposed to match: %v", r)
}
}
}
Expand All @@ -149,24 +118,18 @@ func TestPackageWildcardWithSkip(t *testing.T) {
}

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != len(files) {
t.Error("Matched different number of files")
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), len(files))
}

if err != nil {
log.Fatal(err)
}

for _, r := range result {
matched := false
for _, e := range files {
matched = matched || strings.HasSuffix(r, e)
}
if !matched {
t.Error("Not supposed to match: " + r)
t.Errorf("Not supposed to match: %v", r)
}
}
}
Expand All @@ -189,19 +152,15 @@ func TestComplainForMissingPackages(t *testing.T) {

func TestResolvePackages(t *testing.T) {
result, err := ResolvePackages([]string{"github.com/mgechev/dots/fixtures/pkg/foo/...", "github.com/mgechev/dots/fixtures/pkg/baz"}, []string{})

if err != nil {
t.Error("Got errors")
t.Fatal(err)
}

if len(result) != 1 {
t.Error("Matched different number of files")
t.Fatalf("Matched different number of files: got=%v, want=%v", len(result), 1)
}

for _, pkg := range result {
if len(pkg) == 0 {
t.Error("Empty package")
}
}

}
Loading