Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postinstall script update #1985

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Postinstall script update #1985

merged 1 commit into from
Jun 27, 2017

Conversation

vyakymenko
Copy link
Contributor

Since angular/angular#9359 issue is resolved, we can remove unused postinstall task for rx.js bundle.

@vyakymenko
Copy link
Contributor Author

@mgechev , can you take a look for this one?

@mgechev
Copy link
Owner

mgechev commented Jun 23, 2017

Yes, I will review & merge tomorrow.

@mgechev mgechev merged commit cd89d75 into mgechev:master Jun 27, 2017
@Karasuni
Copy link
Contributor

Karasuni commented Jun 27, 2017

This PR breaks the main application. (reported by @mindietea and @kurtdaveting)

Tested with both npm run start and npm run build.prot.rollup.aot

Uncaught ReferenceError: require is not defined
    at Rx.ts:5
(anonymous) @ Rx.ts:5
(index):60 SyntaxError: Unexpected token <
    at eval (<anonymous>)

(screenshot)

reverting back to the previous version does still give an error but allows the app to run but with the following error:

[23:36:06] Starting 'build.js.dev'...
C:/dev/angular-seed/node_modules/rxjs/Subject.d.ts(16,22): error TS2415: Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
    Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
      Type 'Observable<T>' is not assignable to type 'Observable<R>'.
        Type 'T' is not assignable to type 'R'.
[23:36:10] TypeScript: 1 semantic error
[23:36:10] TypeScript: emit succeeded (with errors)

This could be related to rxjs (version 5.4.1)

@vyakymenko
Copy link
Contributor Author

vyakymenko commented Jun 28, 2017

@Karasuni , thanks for the info about rxjs problem I also finded same info in AppVeyor.
Have resolved this issue in new PR:
#1994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants