Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(export): export function to processed DOM loaded after DOM ready #87

Closed
wants to merge 1 commit into from

Conversation

PikachuEXE
Copy link

Similar to #59 but with no tab -> space conversion
This one does not update change log / version / minified JS
Also different to #59 the existing arguments is moved into the function as default arguments
Let me know what you think

@mfranzke
Copy link
Owner

mfranzke commented Apr 20, 2020

@PikachuEXE, thanks a lot for your contribution !

I‘m mainly struggling with the Internet Explorer compatibility down to version 9, that I‘ve accomplished through not necessarily using the latest coolest features (which I would have liked to do so), but mainly written plain old stable JS.
I sadly as well don‘t have the experience with exports and modules etc., so I wouldn‘t be able to judge or lead to solutions that could probably fit for both needs.

What do you think about those aspects? Is there a simple path / solution to come up with compatibility but even also deliver on the needs of current JS tech features?
Elsewhere I would be able to do some research and get some knowledge on this whole topic during these days.

@PikachuEXE
Copy link
Author

Not sure why I forgot UMD pattern
Applied and tested with IE 9
You can test by visiting
https://output.jsbin.com/yomocox

@mfranzke
Copy link
Owner

@PikachuEXE - sadly it took me a while to provide a solution. Do you have the chance to review my implementation provided with #96 ?

@mfranzke mfranzke mentioned this pull request Feb 15, 2021
@PikachuEXE
Copy link
Author

I am using another library right now
What should I do to review changes in #96 ?

@mfranzke
Copy link
Owner

mfranzke commented Mar 4, 2021

@PikachuEXE I've released a beta version of this polyfill: loading-attribute-polyfill@beta - if I could still motivate you to test it and if you're still able even that you're using another library right now (and hopefully I could motivate you to come back), that would be awesome.

@PikachuEXE
Copy link
Author

I have done this

import loadingAttributePolyfill from "loading-attribute-polyfill"
window.loadingAttributePolyfill = loadingAttributePolyfil
  • Run loadingAttributePolyfill.prepareElement(document.querySelector('img')); in browser to ensure the function exists & can be executed

@mfranzke
Copy link
Owner

mfranzke commented Mar 5, 2021

@PikachuEXE , okay, thanks a lot.

@mfranzke mfranzke closed this Mar 7, 2021
@PikachuEXE PikachuEXE deleted the export-lazyload branch March 8, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants