Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM changes tracking with MutationObserver #39

Closed
wants to merge 10 commits into from

Conversation

OgNellis
Copy link

@OgNellis OgNellis commented Oct 29, 2019

@mfranzke
I've added DOM changes tracking with MutationObserver, which would recall 'prepareElements' method

@OgNellis OgNellis changed the title DOM changes tracking via MutationObserver DOM changes tracking with MutationObserver Oct 29, 2019
@mfranzke
Copy link
Owner

Thanks a lot for your support ! I couldn‘t check on this in detail previous to Friday.

@mfranzke
Copy link
Owner

mfranzke commented Nov 10, 2019

I'm mainly thinking about whether it might be better to provide an API to trigger a reinit of the functionality and offering the MutationObserver sample code, so that every site owner could implement this MutationObserver only if needed in their application and those who don't wouldn't have this Observer running at all.

What's your opinion on this?

@mfranzke
Copy link
Owner

@OgNellis - sadly it took me a while to provide a solution. Do you have the chance to review my implementation provided with #96 ?

@mfranzke mfranzke mentioned this pull request Feb 15, 2021
@mfranzke
Copy link
Owner

mfranzke commented Mar 4, 2021

@OgNellis I've released a beta version of this polyfill: loading-attribute-polyfill@latest that provides the prepareElements as a public method to be called from outside, like within a MutationObserver. Do you still have the chance to recheck this aspect?
Again, sorry for the long delay.

@mfranzke mfranzke closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants