Use YAML.to_json instead of YAML.dump #233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
make_our_yaml_json
branch
from
b4ef377
to
adecad0
Compare
We're not using any features of YAML outside of dictionaries and lists (hashes and arrays), so why not let our data be parseable by YAML _and_ JSON?
etagwerker
force-pushed
the
make_our_yaml_json
branch
from
adecad0
to
34c85bb
Compare
etagwerker
reviewed
Nov 6, 2021
There was a problem hiding this comment.
@bf4 Are you still interested in merging these changes? What's the goal with this PR?
| # Renders the result of the result_hash into a yaml serialization | ||
| # ready for writing out to a file. | ||
| # | ||
| # @return YAML | ||
| # A YAML object containing the results of the result generation | ||
| # process | ||
| def as_yaml | ||
| result_hash.to_yaml | ||
| YAML.to_json(result_hash) |
There was a problem hiding this comment.
@bf4 This seems a bit confusing, shouldn't we try to rename the method to be as_json instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.