Refactor ping packet handling in WebsocketTransport #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed PING_PACKET from a Buffer to an object for improved clarity. - Updated the method call from `this.write(PING_PACKET)` to `this.send(PING_PACKET)` to reflect the new structure. This change enhances the readability and maintainability of the code related to pinging in the WebSocket transport layer.
|
The issue is that when ping is send as a buffer - it is treated as a binary here Which results in Trring to read 32 bytes from a 16byte buffer, this lead to server failure. Alternative solution would be to use "{}" without the buffer and test to see if it works that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-server connection ping error
this.write(PING_PACKET)tothis.send(PING_PACKET)to reflect the new structure.This change enhances the readability and maintainability of the code related to pinging in the WebSocket transport layer.
npm t)npm run fix)