Fix EADDRINUSE impress issue #1890 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarhiievHE
changed the title
MarhiievHE
changed the title
tshemsedinov
requested changes
Sep 29, 2023
lib/server.js
Outdated
| if (err.code !== 'EADDRINUSE') return; | ||
| tryToStartCounter++; | ||
| if (tryToStartCounter > 3) return void this.emit('error', err); |
There was a problem hiding this comment.
Add retry to options with default value from const instead of hardcoding 3
lib/server.js
Outdated
| @@ -10,6 +10,7 @@ const { MetaReadable, MetaWritable, chunkDecode } = require('./streams.js'); | |||
|
|
|||
| const SHORT_TIMEOUT = 500; | |||
| const EMPTY_PACKET = Buffer.from('{}'); | |||
| let tryToStartCounter = 0; | |||
There was a problem hiding this comment.
Move to Server instance because we may have multiple Server instances
tshemsedinov
reviewed
Oct 3, 2023
tshemsedinov
reviewed
Oct 3, 2023
tshemsedinov
reviewed
Oct 3, 2023
tshemsedinov
reviewed
Oct 3, 2023
tshemsedinov
approved these changes
Oct 3, 2023
tshemsedinov
changed the title
tshemsedinov
added a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for solving the problem: metarhia/impress#1890
npm t)npm run fmt)