WIP: Add support for http protocol requests #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nechaido
force-pushed
the
add-support-for-http-protocol-requests
branch
from
90eb7db to
c27a016
Compare
tshemsedinov
approved these changes
Jun 18, 2021
tshemsedinov
force-pushed
the
add-support-for-http-protocol-requests
branch
from
7629ab0 to
9cf2be1
Compare
|
Debased and simplified, ready for landing @nechaido |
nechaido
commented
Jun 21, 2021
lib/client.js
Outdated
| @@ -92,7 +92,7 @@ class Metacom extends EventEmitter { | |||
| const target = interfaceName + '/' + methodName; | |||
| const packet = { call: callId, [target]: args }; | |||
| const dest = new URL(this.url); | |||
| const protocol = dest.protocol === 'ws:' ? 'http' : 'https'; | |||
| const protocol = dest.protocol.endsWith('s') ? 'https' : 'http'; | |||
There was a problem hiding this comment.
@tshemsedinov both ws and wss end with s that's why I used the check I used.
tshemsedinov
force-pushed
the
add-support-for-http-protocol-requests
branch
from
7743daf to
9cf2be1
Compare
|
See client-side implementation: https://github.com/metarhia/metacom/tree/master/dist |
tshemsedinov
changed the title
|
I'd prefer to have the same version for both node and browser clients. |
|
Looks like not actual as of 2024-02-12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, request to
http://localhost/apiwould be transformed into requests tohttps://localhost/api, this will result in an obvious but hard-to-track OpenSSL error.