Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate recommendation identifiers #48

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Translate recommendation identifiers #48

merged 1 commit into from
Oct 9, 2024

Conversation

mico
Copy link
Contributor

@mico mico commented Sep 28, 2024

related #43
translate only recommendation identifiers, doesn't affect annexes.

opoudjis
opoudjis requested changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@opoudjis opoudjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Annex to" also needs to be translated, as does "OB".

e.g. for French, currently generating Annex to UIT-R OB No. 1000. We need Annexe au BE de l'UIT-R 1000.

@mico
Copy link
Contributor Author

mico commented Oct 8, 2024 •
edited
Loading

"Annex to" also needs to be translated, as does "OB".

e.g. for French, currently generating Annex to UIT-R OB No. 1000. We need Annexe au BE de l'UIT-R 1000.

@opoudjis This pull request only for recommendation translation. I'll do for annexes in the next pull request.

@opoudjis
Copy link
Contributor

opoudjis commented Oct 8, 2024

OK then, you can merge this.

@mico mico merged commit c72ce7e into main Oct 9, 2024
13 of 14 checks passed
@mico mico deleted the translate-recommendations branch October 9, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoudjis opoudjis opoudjis requested changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mico @opoudjis