Rename #get_params to #to_h method

lib/pubid/core/identifier/base.rb

@@ -59,10 +59,10 @@ def initialize(publisher:, number:, copublisher: nil, part: nil, type: nil,
 
       # @return [String] Rendered URN identifier
       def urn
-        Renderer::Urn.new(get_params).render
+        Renderer::Urn.new(to_h).render
       end
 
-      def get_params
+      def to_h
         instance_variables.map do |var|
           # XXX: temporary hack to prepare typed_stage for rendering
           # probably need to convert typed_stage to class, now we store
@@ -76,12 +76,12 @@ def get_params
       end
 
       def ==(other)
-        get_params == other.get_params
+        to_h == other.to_h
       end
 
       # Render identifier using default renderer
       def to_s
-        self.class.get_renderer_class.new(get_params).render
+        self.class.get_renderer_class.new(to_h).render
       end
 
       def typed_stage_abbrev

lib/pubid/core/renderer/base.rb

@@ -44,9 +44,9 @@ def prerender_params(params, opts)
     def render_supplement(supplement_params, **args)
       base = if supplement_params[:base].type == :amd
                # render inner amendment (cor -> amd -> base)
-               render_supplement(supplement_params[:base].get_params, **args)
+               render_supplement(supplement_params[:base].to_h, **args)
              else
-               self.class.new(supplement_params[:base].get_params).render_base_identifier(
+               self.class.new(supplement_params[:base].to_h).render_base_identifier(
                  # always render year for identifiers with supplement
                  **args.merge({ with_date: true }),
                )

spec/pubid_core/identifier/base_spec.rb

@@ -291,6 +291,14 @@ def self.get_identifier
       end
     end
   end
+
+  describe "#to_h" do
+    subject { TestIdentifier.create(**params).to_h }
+
+    let(:params) { { type: "tr", number: 1, publisher: "ISO" } }
+
+    it { expect(subject).to eq(params) }
+  end
 end
 
 class TR < Pubid::Core::Identifier::Base