Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading order and make specs runnable #7

Merged
merged 17 commits into from
Oct 27, 2024
Merged

Fix loading order and make specs runnable #7

merged 17 commits into from
Oct 27, 2024

Commits on Oct 25, 2024

  1. ISSUE#1 Fix load order and make specs run

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    40e1338 View commit details
    Browse the repository at this point in the history

  2. ISSUE#1 Skip test

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    49792e5 View commit details
    Browse the repository at this point in the history

  3. ISSUE#1 Add missing gem

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3da3adf View commit details
    Browse the repository at this point in the history

  4. ISSUE#1 Fix linter errors

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    897029e View commit details
    Browse the repository at this point in the history

  5. ISSUE#1 Use zeitwerk as the code loader since autoload is not recomme… 

    …nded
    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7f04be6 View commit details
    Browse the repository at this point in the history

  6. ISSUE#1 Tweak

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    319a6df View commit details
    Browse the repository at this point in the history

  7. include BasicText after relevant classes have been loaded

    @zznull @ronaldtse
    zznull authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f92032c View commit details
    Browse the repository at this point in the history

  8. stub classes beforehand and then require actual definitions in correc… 

    …t order in one place and remove require_relative from the class definitions
    @zznull @ronaldtse
    zznull authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b19d8ba View commit details
    Browse the repository at this point in the history

  9. Issue #1 replaced require_relative with autoload

    @zznull @ronaldtse
    zznull authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    55bd4ac View commit details
    Browse the repository at this point in the history

  10. Fix autoload with zeitwerk

    @valerii-pohrebniak-rg @ronaldtse
    valerii-pohrebniak-rg authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e3b1a03 View commit details
    Browse the repository at this point in the history

  11. remove logging of zeitwerk load

    @valerii-pohrebniak-rg @ronaldtse
    valerii-pohrebniak-rg authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7ef7d5d View commit details
    Browse the repository at this point in the history

  12. remove zeitwerk from gemfile, downgrade its version, fix order to run… 

    … rspec properly
    @valerii-pohrebniak-rg @ronaldtse
    valerii-pohrebniak-rg authored and ronaldtse committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    827a087 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'fix-loading-order' into issue-1

    @Novtopro
    Novtopro authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    98baf06 View commit details
    Browse the repository at this point in the history

  14. ISSUE#1 Fix test

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fd01ed8 View commit details
    Browse the repository at this point in the history

  15. ISSUE#1 Tweak

    @Novtopro
    Novtopro committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b06df81 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Merge pull request #5 from Novtopro/issue-1 

    ISSUE#1 Fix load order and make specs run
    @ronaldtse
    ronaldtse authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    cd78dc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. add module autoincluder, drop include_basic_text file

    @ronaldtse
    ronaldtse committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    a6d258f View commit details
    Browse the repository at this point in the history