Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent fix for Document 001 v4 #146

Merged
merged 13 commits into from
Aug 21, 2024
Merged

Urgent fix for Document 001 v4 #146

merged 13 commits into from
Aug 21, 2024

Conversation

ronaldtse
Copy link
Contributor

@ronaldtse ronaldtse commented Aug 20, 2024

This is clean up necessary after #129 .

Fixes #145

@ronaldtse
Copy link
Contributor Author

Document compilation errors:

FYI @opoudjis :

Style: (ID _dmelement_dislocationtype_xml): More than 1 ordered list in a numbered clause
undefined method `previous=' for nil
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess_footnotes.rb:30:in `footnote_backlinks1'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess_footnotes.rb:41:in `block in footnote_backlinks'
gems/nokogiri-1.16.7-arm64-darwin/lib/nokogiri/xml/node_set.rb:235:in `block in each'
gems/nokogiri-1.16.7-arm64-darwin/lib/nokogiri/xml/node_set.rb:234:in `upto'
gems/nokogiri-1.16.7-arm64-darwin/lib/nokogiri/xml/node_set.rb:234:in `each'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess_footnotes.rb:38:in `each_with_index'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess_footnotes.rb:38:in `footnote_backlinks'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess.rb:29:in `html_cleanup'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess.rb:16:in `toHTML'
gems/isodoc-2.11.1/lib/isodoc/html_function/postprocess.rb:11:in `postprocess'
gems/isodoc-2.11.1/lib/isodoc/convert.rb:171:in `convert'
gems/isodoc-2.11.1/lib/isodoc/html_convert.rb:26:in `convert'
gems/metanorma-plateau-0.1.3/lib/metanorma/plateau/processor.rb:41:in `output'
gems/metanorma-2.0.3/lib/metanorma/compile/compile.rb:175:in `process_output_threaded'
gems/metanorma-2.0.3/lib/metanorma/compile/compile.rb:167:in `block in process_exts1'
gems/metanorma-2.0.3/lib/metanorma/util/worker_pool.rb:21:in `block (3 levels) in init_thread'
<internal:kernel>:187:in `loop'
gems/metanorma-2.0.3/lib/metanorma/util/worker_pool.rb:19:in `block (2 levels) in init_thread'
gems/metanorma-2.0.3/lib/metanorma/util/worker_pool.rb:18:in `catch'
gems/metanorma-2.0.3/lib/metanorma/util/worker_pool.rb:18:in `block in init_thread'

Copy link
Contributor

@ReesePlews ReesePlews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ronaldtse thanks for flagging these. i looked at the xml file ( DataQualityAttribute_lod1HeightType.xml ) but i am not seeing the "(使用不可)" characters in the original xml file, or in the table after doing a generate. i could only check the HTML and this table seems to be in the area that properly compiles. here is an image.

image

i wonder if they were something that happened during the initial conversion?

let me wait awhile until the other errors are corrected and i will come back to this.

@ronaldtse
Copy link
Contributor Author

@ReesePlews the document currently does not compile yet, so this must be an older version.

@ronaldtse
Copy link
Contributor Author

@opoudjis
Copy link
Contributor

Done, you will need to pull isodoc.

@ReesePlews
Copy link
Contributor

i noticed in the build that one of the xml codelist files is misspelled in the code...

FirePreventionDIstrict_usage.xml

is on disk actually named

FirePreventionDistrict_usage.xml

ReesePlews and others added 8 commits August 21, 2024 09:20
i noticed in the build that one of the xml codelist files is misspelled in the code...

FirePreventionDIstrict_usage.xml

is on disk actually named

FirePreventionDistrict_usage.xml
also ScenicDistrict_usage.xml was incorrectly misspelled
ScenicDIstrict_usage.xml
@ronaldtse ronaldtse merged commit 7cda46a into main Aug 21, 2024
1 check failed
@ronaldtse ronaldtse deleted the urgent-fix-001-v4 branch August 21, 2024 06:13
@ReesePlews
Copy link
Contributor

i think #149 also needs to be in the list of issues the Plateau team should check

@ronaldtse
Copy link
Contributor Author

@ReesePlews yes, updated list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(URGENT) render of gml_dict failure
3 participants