Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hyperlinking from schema docs (schemas-only): https://github.com/… #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix hyperlinking from schema docs (schemas-only): https://github.com/… #118

wants to merge 1 commit into from

Conversation

opoudjis
Copy link
Contributor

…metanorma/iso-10303/issues/41

Metanorma PR checklist

@opoudjis opoudjis requested a review from ronaldtse June 27, 2024 15:59
ronaldtse
ronaldtse reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run Rubocop -A before commit

@opoudjis
Copy link
Contributor Author

I'd have to rubocop all of metanorma-plugin-lutaml, it does not adhere to our rubocop...

@ronaldtse
Copy link
Contributor

@opoudjis : @kwkwan will reimplement the lutaml-express code with Liquid::Drop which prevents us from needing to serialize before going into Liquid, which will greatly enhance performance.

@opoudjis
Copy link
Contributor Author

opoudjis commented Aug 2, 2024

Good, thank you!

@opoudjis
Copy link
Contributor Author

@ronaldtse @kwkwan Update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse left review comments

Assignees

@ronaldtse ronaldtse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opoudjis @ronaldtse