Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/presxml oct24 #1233

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/presxml oct24 #1233

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111fa72
move figure key from HTML to Presentation XML: https://github.com/met…
opoudjis Oct 29, 2024
132371d
Move Figure Key insertion from isodoc/function to Presentation XML: h…
opoudjis Oct 29, 2024
e65d610
rspec
opoudjis Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile.devel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
gem "metanorma-standoc", git: "https://github.com/metanorma/metanorma-standoc", branch: "main"
gem "isodoc", git: "https://github.com/metanorma/isodoc", branch: "fix/presxml-oct24"
1 change: 0 additions & 1 deletion lib/isodoc/iso/base_convert.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ def figure_parse1(node, out)
measurement_units(node, out)
out.div **figure_attrs(node) do |div|
node.children.each do |n|
figure_key(out) if n.name == "dl"
n.name == "note" && n["type"] == "units" and next
parse(n, div) unless n.name == "name"
end
Expand Down
2 changes: 2 additions & 0 deletions lib/isodoc/iso/presentation_xml_convert.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def annex(isoxml)
end

def figure1(node)
figure_fn(node)
figure_key(node.at(ns("./dl")))
lbl = @xrefs.anchor(node["id"], :label, false) or return
figname = node.parent.name == "figure" ? "" : "#{@i18n.figure} "
conn = node.parent.name == "figure" ? "  " : " — "
Expand Down
Loading