Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser work #117

Merged
merged 13 commits into from
Aug 21, 2024
Merged

Parser work #117

merged 13 commits into from
Aug 21, 2024

Conversation

xyz65535
Copy link
Contributor

@xyz65535 xyz65535 commented Jul 28, 2024

This PR is related to #52

This PR does the following:

  • Identifying specific problems with the parser
  • Making grammar improvements
  • Verifying that these improvements increase roundtrip capability for the rice-2023 document
  • Ensuring all existing tests still pass to avoid introducing bugs

Regarding rice-2023 document roundtripping: without this pull request, only 18 out of 48 files were parsed, meaning just 37% were processed, and 655 lines remained unparsed. Now, all 48 files are parsed without breaking, leaving only 104 lines unparsed. Adding all together, it used to be that 1,746 lines were unparsed before, so this pull request, as of today, makes a 94% reduction in unparsed lines.

Metanorma PR checklist

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (a32cdeb) to head (e4248c5).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   98.34%   98.35%   +0.01%     
==========================================
  Files          46       46              
  Lines        1327     1337      +10     
==========================================
+ Hits         1305     1315      +10     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -7,7 +7,7 @@ class Title < Base

def initialize(content, level, options = {})
@level_int = level
@level_int = level.length if level.is_a?(String)
# @level_int = level.length - 1 if level.is_a?(String)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been discussed before on the tracker and needs to be kept as-is.

@xyz65535 xyz65535 changed the title Parser work [WIP] Parser work Aug 17, 2024
@webdev778 webdev778 merged commit 984a901 into metanorma:main Aug 21, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants