Parser work #117
Merged
Parser work #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 98.34% 98.35% +0.01%
==========================================
Files 46 46
Lines 1327 1337 +10
==========================================
+ Hits 1305 1315 +10
Misses 22 22 ☔ View full report in Codecov by Sentry. |
hmdne
reviewed
Aug 8, 2024
| @@ -7,7 +7,7 @@ class Title < Base | |||
|
|
|||
| def initialize(content, level, options = {}) | |||
| @level_int = level | |||
| @level_int = level.length if level.is_a?(String) | |||
| # @level_int = level.length - 1 if level.is_a?(String) | |||
There was a problem hiding this comment.
This has been discussed before on the tracker and needs to be kept as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #52
This PR does the following:
Regarding rice-2023 document roundtripping: without this pull request, only 18 out of 48 files were parsed, meaning just 37% were processed, and 655 lines remained unparsed. Now, all 48 files are parsed without breaking, leaving only 104 lines unparsed. Adding all together, it used to be that 1,746 lines were unparsed before, so this pull request, as of today, makes a 94% reduction in unparsed lines.
Metanorma PR checklist