-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "rn" by "cdm" (1) #4484
Conversation
See issue metamath#4470: Label changes: * ~ffelrnd -> ~ffelcdmd (used 1113 times) * ~ffelrnda -> ~ffelcdmda (used 1119 times) * ~ffelrni -> ~ffelcdmi (used 229 times) * ~ffelrn -> ~ffelcdm (used 492 times) "cdm" added to list of abbreviations (in comment for ~conventions-labels)
You have a 68,000 line diff in set.mm. Could you please investigate why? |
Thank you, @icecream17 , for working out the differences. Besides the part of the additional abbreviation in the conventions, there are the following 4 label changes of the theorems : The rest is actually only changes within proofs (and since the labels became 1 character longer, the proofs had to be reformatted - all done automatically by |
changes-set.txt
Outdated
17-Dec-24 ffelrnd ffelcdmd | ||
17-Dec-24 ffelrnda ffelcdmda | ||
17-Dec-24 ffelrni ffelcdmi | ||
17-Dec-24 ffelrn ffelcdm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ffvelcdm
$p |- ( ( F : A --> B /\ C e. A ) -> ( F ` C ) e. B ) $ =
17-Dec-24 ffelrnd ffelcdmd | |
17-Dec-24 ffelrnda ffelcdmda | |
17-Dec-24 ffelrni ffelcdmi | |
17-Dec-24 ffelrn ffelcdm | |
17-Dec-24 ffvelrnd ffvelcdmd | |
17-Dec-24 ffvelrnda ffvelcdmda | |
17-Dec-24 ffvelrni ffvelcdmi | |
17-Dec-24 ffvelrn ffvelcdm |
Although I suggested a different naming convention at #4466 (comment) I don't really object to My main comment is that neither the commit message nor the change to |
I think
You are absolutely right: one typo, and then many times copy&paste .., I'll correct that. |
Some theorems having "codomain" in the comment, "rn" in the label, but no "ran" in their statement or hypotheses are renamed ("rn" replaced by "cdm" for "codomain"), see issue #4470:
Label changes:
"cdm" added to list of abbreviations (in comment for ~conventions-labels)