Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure part 9 #4298

Merged
merged 10 commits into from
Oct 19, 2024
Merged

Restructure part 9 #4298

merged 10 commits into from
Oct 19, 2024

Conversation

zwang123
Copy link
Contributor

#4253

Changes

  • Moved: codu to odubas -> top
  • Moved: pospropd to oduposb -> after isposix
  • Moved: meet0 to odujoin and poslubmo  to posglbd -> after meetcom
  • Moved: odulatb and odulat -> after islat
  • Moved: oduclatb -> after clatglbcl2 
  • Renamed: posglbd -> posglbdg
  • Moved: The distributive lattice of sets under inclusion -> after distributive lattices
  • Moved: latmass to latdisd -> lattice section
  • Reversed order for join0 and meet0 and for odu*, for consistency
  • Added tosets and complete lattices section
  • Changed other sections based on BJ's proposal (directed set and proset could be separated but the sections would become very short so I am not doing it now...)
  • etc

Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now. Let's see how it looks in HTML. Maybe we need some finetuning then.

Comment on lines +218967 to +218969

See commented-out notes for lattices as relations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ones ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there is no definition for LatRel in set.mm, and the related theorems are commented out. Maybe a separate issue should be created to revise and activate all these theorems in (current) subsection 9.2.6 "Posets and lattices as relations" (between ~tsrss and ~ledm). Or they should be deleted if they are useless. @digama0 you revised already some of these theorems in 2023 - what do you think?

Nevertheless, I will merge this PR now (to see how the new structure will show up in HTML), because there are 4 approvals.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there is no definition for LatRel in set.mm, and the related theorems are commented out. Maybe a separate issue should be created to revise and activate all these theorems in (current) subsection 9.2.6 "Posets and lattices as relations" (between ~tsrss and ~ledm). Or they should be deleted if they are useless.

Issue #4302 opened for this topic.

@avekens avekens merged commit 2c23f68 into metamath:develop Oct 19, 2024
10 checks passed
@zwang123 zwang123 deleted the restructure-part-9 branch October 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants