Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dftermo2 #4170

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add dftermo2 #4170

merged 2 commits into from
Aug 29, 2024

Conversation

zwang123
Copy link
Contributor

@zwang123 zwang123 commented Aug 29, 2024

#4142

Proved that |- TermO = ( c e. Cat |-> ( InitO ` ( oppCat ` c ) ) ) and |- InitO = ( c e. Cat |-> ( TermO ` ( oppCat ` c ) ) ). listed right after termoid

Copy link
Contributor

@tirix tirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Usually contributions go first into the user's Mathbox, then get moved if used elsewhere or considered worthy, but I think here it's clearly the case.

@zwang123
Copy link
Contributor Author

zwang123 commented Aug 29, 2024

Great! Usually contributions go first into the user's Mathbox, then get moved if used elsewhere or considered worthy, but I think here it's clearly the case.

I see. Actually I added dfinito3 and dftermo3 and other dependent theorems for the original proposal in #4142. Do you think I need to put it in Mathbox first?

zwang123#1

@icecream17
Copy link
Contributor

I think the theorems in zwang123#1 are useful enough to not be in a mathbox

@zwang123
Copy link
Contributor Author

I think the theorems in zwang123#1 are useful enough to not be in a mathbox

Do I merge zwang123#1 before this PR or do I create a separate PR for the third definition?

@benjub
Copy link
Contributor

benjub commented Aug 29, 2024

Congratulations on your first contribution, @zwang123 !

It's indeed important enough to skip the mathbox stage, which is the default for contributions when one needs some time to evaluate their importance (for instance, to see what later theorems use it). Here, their importance is obvious so no need for that stage.

Actually, your dftermo2 should be the "official" definition, and we may make the change in a future PR. But, as you noticed, the variable-free definition does not work for the moment because of the domains. This is something we may want to fix first (simply by changing the domains of these functions).

@benjub benjub merged commit 5240c5f into metamath:develop Aug 29, 2024
10 checks passed
@zwang123 zwang123 mentioned this pull request Aug 30, 2024
@david-a-wheeler
Copy link
Member

Congratulations on your first contribution, @zwang123 !

I'd also like to give congrats to @zwang123 !! We love to have new contributors. Welcome!

@tirix
Copy link
Contributor

tirix commented Sep 3, 2024

Welcome to the very select club of set.mm contributors @zwang123 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants