-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dftermo2 #4170
Add dftermo2 #4170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Usually contributions go first into the user's Mathbox, then get moved if used elsewhere or considered worthy, but I think here it's clearly the case.
I see. Actually I added |
I think the theorems in zwang123#1 are useful enough to not be in a mathbox |
Do I merge zwang123#1 before this PR or do I create a separate PR for the third definition? |
Congratulations on your first contribution, @zwang123 ! It's indeed important enough to skip the mathbox stage, which is the default for contributions when one needs some time to evaluate their importance (for instance, to see what later theorems use it). Here, their importance is obvious so no need for that stage. Actually, your dftermo2 should be the "official" definition, and we may make the change in a future PR. But, as you noticed, the variable-free definition does not work for the moment because of the domains. This is something we may want to fix first (simply by changing the domains of these functions). |
Welcome to the very select club of |
#4142
Proved that
|- TermO = ( c e. Cat |-> ( InitO ` ( oppCat ` c ) ) )
and|- InitO = ( c e. Cat |-> ( TermO ` ( oppCat ` c ) ) )
. listed right after termoid