Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit credits, add comments #3923

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Edit credits, add comments #3923

merged 1 commit into from
Apr 18, 2024

Conversation

GinoGiotto
Copy link
Contributor

This PR applies @avekens request #3905 (comment) of adding comments and credits to theorems avoiding ax-13. The criteria goes as follows: scan through the discouraged theorems using ax-13 and check out whether they have a newer weaker version; if they have one then replace the credit of the weaker version with the contributor of the original one. As default I only added the original contributor and not the following revisers, as it's not always clear to me whether they play a role on the new version (specifically it's not always stated whether the revison concerned the old proof only and not the statement itself). This may change with the review process.

Additional changes:

  • Replace usages of ralcom2 and ralcom2w with ralcom, which uses less axioms (and delete my version ralcom2w since it's just redundant and never used).

  • Delete my version cbvrabcsfw since it was only added to avoid ax-13, but it's never used.

  • Delete my mathbox. The information it contains it's not relevant anymore and I'm not planning to add other stuff into it. So, to avoid waste of space, it can be removed.

Copy link
Contributor

@benjub benjub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through it and it looks good to me.
Thanks for that scrupulous work.

@wlammen
Copy link
Contributor

wlammen commented Apr 17, 2024

The way the credits are handled, is not convincing to me, to be honest. As far as my person is concerned, I do not care much. But in principle is adding DV conditions and finding a proof for such a specialized theorem an act of ingeniosity in its own right in most cases. The proofs do not generally carry over (see https://us.metamath.org/mpeuni/spei.html /https://us.metamath.org/mpeuni/speiv.html for example). This is similar to specializing a group to a symmetric group, for example. Extra conditions are added, allowing for a different theory, in the end with its own rules and proof techniques. Why should one specializing a general rule about groups to symmetric ones not appear as contributor of that theorem, but as a reviser of the one in the more general context? Why are DV conditions handled differently to adding/modifying a hypothesis line?

I don't think this comment should block this PR. But it can serve as a starting point for a discussion after which we adapt our conventions accordingly, and corrections in set.mm can be made. In case it is supported by some, I will open an issue regarding this topic.

Copy link
Contributor

@wlammen wlammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in my comment above.

@wlammen wlammen merged commit ac82480 into metamath:develop Apr 18, 2024
10 checks passed
@GinoGiotto GinoGiotto deleted the comments branch April 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants