Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc #3734

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Misc #3734

merged 2 commits into from
Jan 3, 2024

Conversation

benjub
Copy link
Contributor

@benjub benjub commented Jan 1, 2024

Very small PR:

@benjub
Copy link
Contributor Author

benjub commented Jan 1, 2024

It looks like the CI does not run the latest Metamath version (looking at https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326).

It looks like it correctly downloads the latest version (https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326#step:4:34) but does not run it (it runs a 0.198 whereas when I compile locally the file downloaded at that address, I correctly have a 0.199.pre version).

So probably it uses a cached version. This may be due to the error in the script (see https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326#step:5:5 : error since the needed line above has been commented out).

@avekens
Copy link
Contributor

avekens commented Jan 2, 2024

It looks like the CI does not run the latest Metamath version (looking at https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326).

It looks like it correctly downloads the latest version (https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326#step:4:34) but does not run it (it runs a 0.198 whereas when I compile locally the file downloaded at that address, I correctly have a 0.199.pre version).

So probably it uses a cached version. This may be due to the error in the script (see https://github.com/metamath/set.mm/actions/runs/7378794531/job/20074350326#step:5:5 : error since the needed line above has been commented out).

Which is the official latest version of metamath.exe? The latest designated in https://us.metamath.org/mpeuni/mmrecent.html is 0.198, but on https://us.metamath.org/index.html, 0.199pre is available for a download (unfortunately, no version is mentioned in the text). The suffix "pre", however, seems to indicate that this is not an official/stable version...

@benjub
Copy link
Contributor Author

benjub commented Jan 3, 2024

It looks like the workflow file used (https://github.com/metamath/set.mm/actions/runs/7378794531/workflow?pr=3734)is still the old one, and not the one from #3738). I don't know how to update that.

@tirix
Copy link
Contributor

tirix commented Jan 3, 2024

The workflow used is probably the one from this branch, which does not have the changes from the develop branch yet.
So maybe you should first rebase your branch benjub:misc with develop's latest changes.

@tirix tirix merged commit e397dfb into metamath:develop Jan 3, 2024
10 checks passed
@benjub benjub deleted the misc branch January 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants