Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #174, more parser checks and more parser tests #175

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix for #174, more parser checks and more parser tests #175

merged 2 commits into from
Jan 13, 2025

Conversation

tirix
Copy link
Collaborator

@tirix tirix commented Jan 5, 2025

Fixes #174
Adds two more error checks when parsing $t and $j commands:

  • checks that a command is properly closed with a semicolon,
  • checks that a space or a semicolon must always follow a quoted command token (String).

Adds the corresponding tests, and more.

@tirix tirix requested a review from digama0 January 5, 2025 16:52
@tirix tirix mentioned this pull request Jan 6, 2025
Merged
@tirix tirix merged commit bda840f into metamath:main Jan 13, 2025
4 checks passed
@tirix tirix deleted the fix-174 branch January 13, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in case of malformed commands
1 participant
@tirix