Add test cases about minimization #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #165
This PR contains two tests: the first has a proof that can be automatically minimized, the second one cannot. I designed them to be as similar to each other as possible. This aims to isolate the issue that causes #165 and therefore provide a (hopefully) sound explanation of the phenomenon.
Additional evidence is provided by the fact that my edited version of the minimizer can find the test shortening of
th2inmin_not_found.mm, which the regular minimizer cannot detect.The following comments [1] [2] have been very helpful to figure out the issue, and the test cases presented in this PR have been inspired by them.