Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test bmo release 0.6 with golang 1.22 #823

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Test bmo release 0.6 with golang 1.22 #823

merged 1 commit into from
Jul 26, 2024

Conversation

NymanRobin
Copy link
Member

Since golang 1.21 is deprecating in August 2024

Needed for this PR in BMO: metal3-io/baremetal-operator#1824

@NymanRobin
Change bmo release 0.6 testing to golang 1.22
758558a 
Since golang 1.21 is deprecating in August 2024

Signed-off-by: NymanRobin <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2024
@NymanRobin NymanRobin mentioned this pull request Jul 25, 2024
Merged
@adilGhaffarDev
Copy link
Member

/lgtm
/approve

/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 25, 2024

/lgtm

@NymanRobin
Copy link
Member Author

/cc @Sunnatillo @mboukhalfa

Sunnatillo
Sunnatillo reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@metal3-io-bot metal3-io-bot merged commit 7da0858 into metal3-io:main Jul 26, 2024
4 of 5 checks passed
@metal3-io-bot
Copy link
Collaborator

@NymanRobin: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Since golang 1.21 is deprecating in August 2024

Needed for this PR in BMO: metal3-io/baremetal-operator#1824

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NymanRobin @adilGhaffarDev @Rozzii @metal3-io-bot @Sunnatillo