Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete crs_reference.md #499

Merged

Conversation

tuminoid
Copy link
Member

Remove obsolete crs_reference.md.

Based on #447 (comment) and checking the content, it is indeed obsolete.

Fixes #446

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2025
@tuminoid
Copy link
Member Author

/cc @adilGhaffarDev @lentzi90

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@tuminoid
Copy link
Member Author

/hold
for thinking about #499 (comment)

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2025
Remove obsolete crs_reference.md.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/remove-obsolete-crs-reference branch from f11ccb7 to a2bc635 Compare January 21, 2025 06:34
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2025
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The data is still there in the git history if we ever need it. Better to delete it from main to avoid confusion with the no-longer-existing APIs.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
@tuminoid
Copy link
Member Author

/lgtm The data is still there in the git history if we ever need it. Better to delete it from main to avoid confusion with the no-longer-existing APIs.

That is true.
/unhold

I've created #501 to create new documentation on CRs with images.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@metal3-io-bot metal3-io-bot merged commit dea1cde into metal3-io:main Jan 21, 2025
8 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/remove-obsolete-crs-reference branch January 21, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dead links at crs_reference.md
4 participants