FS-927: add mtcl cmd for uploadbom API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alva8756
force-pushed
the
bom_client
branch
5 times, most recently
from
dbe93de
to
fa8dce6
Compare
Alva8756
force-pushed
the
bom_client
branch
from
fa8dce6
to
aafba69
Compare
jakeschuurmans
approved these changes
Sep 19, 2023
DoctorVin
approved these changes
Sep 19, 2023
| ) | ||
| } | ||
|
|
||
| token, err := auth.AccessToken(ctx, model.BomsServiceAPI, cfg, reauth) |
There was a problem hiding this comment.
This code looks fine, but there is some setup we'll have to do to get BOMService to get things to authenticate properly, unless we're using the same Okta groups and stuff for BOMService as we do for ConditionOrc (and that would probably be fine).
There was a problem hiding this comment.
Thanks for pointing it out.
I am not familiar with okta groups. Currently I found oidc client id 0oaa8kto5lZYascqP5d7, does it matches a group in okta? Can you help provide me a link to the okta configuration that I can learn and play around? In the future we may need to have a separate group for bom service.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add mtcl cmd for uploadbom API
Tested with sandbox server service <--> local bomservice <---> mctl client