Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud profile version classification dates #9

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

Gerrit91
Copy link

@Gerrit91 Gerrit91 commented Dec 3, 2024

This is just a draft.

pkg/apis/core/validation/cloudprofile.go Outdated Show resolved Hide resolved
@@ -168,7 +169,7 @@ func ValidateIPFamilies(ipFamilies []core.IPFamily, fldPath *field.Path) field.E
// k8sVersionCPRegex is used to validate kubernetes versions in a cloud profile.
var k8sVersionCPRegex = regexp.MustCompile(`^([0-9]+\.){2}[0-9]+$`)

var supportedVersionClassifications = sets.New(string(core.ClassificationPreview), string(core.ClassificationSupported), string(core.ClassificationDeprecated))
var supportedVersionClassifications = sets.New(string(core.ClassificationPreview), string(core.ClassificationSupported), string(core.ClassificationDeprecated), string(core.ClassificationUnavailable))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about expired? 😇

pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants