2.x OAuth improvements #2559
Merged
2.x OAuth improvements #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offer the user the options to retry the request, cancel or remove locally stored credentials anyway. This prevents the user being unable to remove local credentials and being stuck with broken credentials due to some technical error.
phw
force-pushed
the
2.x-oauth-improvements
branch
from
e594e31 to
bb9c3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
This PR backports the OAuth improvements from the master branch to 2.x:
This is in preparation of finishing the work to support the new MetaBrainz OAuth, which I will provide next and also backport to 2.x. The goal is to be able to make a 2.15 release to offer a release without deprecated MB login.