Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-3008: Handle OverflowError in extract_year_from_date #2556

Merged
merged 1 commit into from
Dec 3, 2024
Merged

PICARD-3008: Handle OverflowError in extract_year_from_date #2556

merged 1 commit into from
Dec 3, 2024

Conversation

phw
Copy link
Member

@phw phw commented Dec 2, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Picard can crash when loading a release that contains a huge number as the date tag. This is caused by an OverflowError when parsing the date for metadata comparison.

Solution

Handle OverflowError from dateutil.parser.parse in picard.util.extract_year_from_date.

@phw phw requested a review from zas December 2, 2024 16:24
@phw phw added the Bug fix label Dec 2, 2024
zas
zas approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 442dd6a into metabrainz:master Dec 3, 2024
44 checks passed
@phw phw deleted the PICARD-3008-fix-date-parsing-overflow branch December 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas