PICARD-2991: Handle statvfs errors on file rename #2555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
make_short_filename
runs_get_filename_limit
on the basedir, which in turn tries to get filename limits by callingstatvfs
.statvfs
can fail withFileNotFoundError
orPermissionError
.To reproduce:
os.statvfs
fails. On my Linux system this is e.g./run/user/1000/doc
=> File naming failed to load, exception is logged
Solution
_get_filename_limit
the call toos.statvfs
fails, retry on the parent pathFileNotFoundError
orPermissionError
when updating the examples