[WIP] MBS-12761: Convert recording edit form to React #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be able to use the component in our TT forms until all forms are converted (and makes it easier to test without having to fully convert the entity editors to React).
This allows testing the code. We eventually will want to use it in all TT forms and drop the TT version.
This is a lot better for translators than "Add {item}" (and needed for
Estonian at least to actually be translated correctly in a simple way).
For area, we don't want translations though since it's an admin form.
This was a hack needed for JQuery to work on this, but with React it's AFAICT entirely useless.
This matches what we do elsewhere in the codebase.
It makes sense for this to be a reusable component, but then we should reuse it.
This allows us to remove the TextList jquery code that the TT version uses.
This will be needed (or at least helpful) anyway when we use this in a larger React form so we might as well get it ready now.
This is not ideal, but it's the same as in production - and associating it with the repeatable field is invalid HTML.
This seems entirely unused.
reosarevok
force-pushed
the
MBS-12761
branch
3 times, most recently
from
9e1ce85
to
b06b776
Compare
reosarevok
force-pushed
the
MBS-12761
branch
from
b06b776
to
7ee0573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will take a while.